fix(vue): prevent auto-selecting option on input blur when no user input #3772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mochetts
reviewed
Aug 4, 2025
| const hasUserInput = inputValue.trim().length > 0 | ||
|
|
||
| if (hasUserInput) { | ||
| api.selectActiveOption() |
There was a problem hiding this comment.
I don't think blurring the input should ever select an option.
See how shadcn works:
https://ui.shadcn.com/docs/components/combobox
That's what i would expect from a combobox (blurring cancels edition).
|
Is this still something that's being actively worked on? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
This PR resolves issue #3771, where the Vue
<Combobox>would auto-select the active option (typically the first one) when the input was blurred — even if the user didn’t select anything or type.✅ Changes
handleBlurlogic to prevent auto-selection unless:🧪 Tests Added
should not auto-select when input was focused and blurred without typingshould not auto-select the active option when the combobox input is blurredThese regression tests ensure no value is selected unintentionally during blur.
🧠 Context
This behavior was correct in
v1.7.13, but regressed in later versions. This change restores expected UX where blur does not imply selection unless explicitly intended.Let me know if anything needs clarification. Happy to iterate on feedback!